Skip to content

Add the possibility to use the Veros ocean model as the ocean component in ClimaOcean #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 262 commits into
base: main
Choose a base branch
from
Open

Add the possibility to use the Veros ocean model as the ocean component in ClimaOcean #602

wants to merge 262 commits into from

Conversation

@simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Aug 21, 2025

This is an exploratory PR to use ClimaOcean to force a veros setup.

This exercise is also usefull to make sure that ClimaOcean does not necessarily assume that the ocean model comes from Oceananigans but it is flexible enough to handle different ocean configurations.

@simone-silvestri
correct dates
a130e73
@simone-silvestri
Merge remote-tracking branch 'origin/main' into ss/metadata-for-every…
c90b7f9 
…thing
@simone-silvestri
syntax
08b377f
@simone-silvestri
Merge remote-tracking branch 'origin/main' into ss/metadata-for-every…
2eb5556 
…thing
@simone-silvestri
more updates
ba4bce0
@simone-silvestri
all this should work?
68dfdb0
@simone-silvestri
clear comments
f212e88
@simone-silvestri
vestigial code
1a68d4e
@simone-silvestri
works
c318e54
@simone-silvestri
veeery much simplified
79b5935
@simone-silvestri
this part is already done
91e1169
@simone-silvestri
back to working
b6fb198
@simone-silvestri
works
e81bdfb
@simone-silvestri
improve show method
afbd1cc
@simone-silvestri
change names
8599314
@simone-silvestri
go ahead
bb24633
@simone-silvestri
fix it
4f05dbb
@simone-silvestri
this should work
fe6dc72
@simone-silvestri
add a new constructor
787ebc9
@simone-silvestri
set with ECCOMetadatum
7c519a1
@simone-silvestri
some changes
78a53cd
@simone-silvestri
improvement to UI
1e71d67
@simone-silvestri
change examples
4f7fdb2
@simone-silvestri
we don't need this
58662d2
@simone-silvestri
chnages
22c8d08
@simone-silvestri
export ui functions
79f37eb
@simone-silvestri
last date
a98669f
@simone-silvestri
vestigial dates
5405ef3
@simone-silvestri
change docstrings
b2ff520
@simone-silvestri
better like this
992b4d7
navidcy
navidcy reviewed Aug 21, 2025
View reviewed changes
glwagner
glwagner reviewed Aug 21, 2025
View reviewed changes
glwagner
glwagner reviewed Aug 21, 2025
View reviewed changes
glwagner
glwagner reviewed Aug 21, 2025
View reviewed changes
glwagner
glwagner reviewed Aug 21, 2025
View reviewed changes
@simone-silvestri simone-silvestri changed the title Use the Veros ocean model as the ocean component in ClimaOcean Add the possibility to use the Veros ocean model as the ocean component in ClimaOcean Aug 22, 2025
@simone-silvestri simone-silvestri marked this pull request as ready for review August 22, 2025 10:08
@simone-silvestri
Copy link
Collaborator Author

simone-silvestri commented Aug 22, 2025

I think this is ready on the ClimaOcean side of things, I'm not sure whether to add tests or not since it might create issues with CI.
The only thing I need to sort out before merging is this function

ClimaOcean.jl/ext/ClimaOceanPythonCallExt/veros_state_exchanger.jl

Lines 86 to 115 in ac8d821

function fill_net_fluxes!(ocean::VerosOceanSimulation, net_ocean_fluxes)
nx = pyconvert(Int, ocean.setup.state.settings.nx) + 4
ny = pyconvert(Int, ocean.setup.state.settings.ny) + 4
t1 = view(parent(net_ocean_fluxes.u), 1:nx, 1:ny, 1)
t2 = view(parent(net_ocean_fluxes.v), 1:nx, 1:ny, 1)
# TODO: Remove this when they fix veros to
# be able to force with an array instead of Climatology
ta = zeros(size(t1)..., 12)
tb = zeros(size(t2)..., 12)
for t in 1:12
ta[:, :, t] .= t1
tb[:, :, t] .= t2
end
set!(ocean.state.variables, "taux", ta)
set!(ocean.state.variables, "tauy", tb)
# TODO: Add heat flux and salinity flux when they
# fix veros to be able to force with prescribed boundary
# conditions rather than restoring
# t1 = view(parent(net_ocean_fluxes.T), 1:nx, 2:ny+1, 1)
# t2 = view(parent(net_ocean_fluxes.S), 1:nx, 2:ny+1, 1)
# set!(ocean, "temp_flux", t1)
# set!(ocean, "salt_flux", t2)
return nothing
end

which we are sorting out on the veros side today.

@simone-silvestri
Copy link
Collaborator Author

simone-silvestri commented Aug 27, 2025

I think this is ready to merge. We probably have to tweak the extension again after https://github.com/nutrik/veros/tree/atm_coupling is merged into main, and we have space where to fill in salt and temperature flux.

@simone-silvestri simone-silvestri mentioned this pull request Oct 13, 2025
Open
@simone-silvestri simone-silvestri mentioned this pull request Oct 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glwagner glwagner Awaiting requested review from glwagner

@navidcy navidcy Awaiting requested review from navidcy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simone-silvestri @navidcy @glwagner